mxm commented on code in PR #14245:
URL: https://github.com/apache/iceberg/pull/14245#discussion_r2626551685
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/FlinkTypeToType.java:
##########
@@ -137,12 +137,20 @@ public Type visit(TimeType timeType) {
@Override
public Type visit(TimestampType timestampType) {
- return Types.TimestampType.withoutZone();
+ if (timestampType.getPrecision() == 9) {
+ return Types.TimestampNanoType.withoutZone();
+ } else {
+ return Types.TimestampType.withoutZone();
+ }
}
@Override
public Type visit(LocalZonedTimestampType localZonedTimestampType) {
- return Types.TimestampType.withZone();
+ if (localZonedTimestampType.getPrecision() == 9) {
+ return Types.TimestampNanoType.withZone();
+ } else {
+ return Types.TimestampType.withZone();
+ }
Review Comment:
Commenting here again because the other thread has been resolved and somehow
cannot be unresolved. We should handle all precisions here for completion, i.e.
7 and 8 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
