lgingerich commented on issue #1936: URL: https://github.com/apache/iceberg-rust/issues/1936#issuecomment-3658186347
@liurenjie1024 thanks for the feedback. I actually quite like the builder pattern, so I'm not advocating to get rid of that, only that I'm not a fan of how much typed-builder abstracts away. I like using a manual builder as it's much more explicit but of course does require considerable template code. Even if you'd like to keep typed-builder, I'd be happy to take on the work of removing pub fields in structs and any other api-cleanup work you have in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
