dttung2905 opened a new pull request, #658: URL: https://github.com/apache/iceberg-go/pull/658
As outlined in the issue, currently we do not perform field id duplication check in this `IndexNameByID` method. This leads to the issue of last one wins if multiple field ID are presented in the schema https://github.com/apache/iceberg-go/blob/f886a245b43df648b9b42148ed0d77c04f1d34c8/schema.go#L788-L800 https://github.com/apache/iceberg-go/blob/f886a245b43df648b9b42148ed0d77c04f1d34c8/schema.go#L810-L817 I added a quick validation under `ByID()` and panic if duplicates are found and put this schema validation under `init()` as suggested in the issue Fixes https://github.com/apache/iceberg-go/issues/593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
