somasays opened a new pull request, #2829: URL: https://github.com/apache/iceberg-python/pull/2829
## Summary - Added `snapshot_properties` parameter to `Transaction.upsert()` and `Table.upsert()` methods - The properties are passed to both underlying `overwrite()` and `append()` operations, so they are applied to all snapshots created by the upsert - Added test to verify snapshot properties are correctly applied ## Background Currently, the `upsert()` operation doesn't support `snapshot_properties`, while other operations like `append()`, `overwrite()`, and `delete()` do. Since upsert creates multiple snapshots (one from `overwrite()` for updates and one from `append()` for inserts), the `snapshot_properties` are applied to all of them, which is consistent with how `overwrite()` handles properties internally. Closes #2659 ## Test plan - [x] Added `test_upsert_snapshot_properties` test that verifies properties are applied to all snapshots created by upsert - [x] All existing upsert tests pass (22 tests) - [x] All lint checks pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
