singhpk234 commented on code in PR #14824:
URL: https://github.com/apache/iceberg/pull/14824#discussion_r2616522490
##########
core/src/main/java/org/apache/iceberg/rest/ScanTaskIterable.java:
##########
@@ -137,16 +131,50 @@ public void run() {
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
+ failure.compareAndSet(null, new RuntimeException("PlanWorker was
interrupted", e));
Review Comment:
> doubtful that it makes sense to also blow up when signcalComplete is
interrupted because planning is complete at that point, and as a result the
consumer won't see a partial state
I agree, yes, we should just set shutDown to true and not blow up and
hasNext() would just say yup i am done, even without worrying for the case
where the DUMMY_TASK was not inserted due to interruption since it done in the
finally. pushing a fix for the same !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
