amogh-jahagirdar commented on code in PR #14824:
URL: https://github.com/apache/iceberg/pull/14824#discussion_r2615021101
##########
core/src/main/java/org/apache/iceberg/rest/ScanTaskIterable.java:
##########
@@ -202,15 +202,14 @@ public boolean hasNext() {
}
while (true) {
Review Comment:
btw @singhpk234 should the
```
if (remaining == 0
&& !planTasks.isEmpty()
&& !shutdown.get()
&& !initialFileScanTasks.isEmpty()) {
executorService.execute(new PlanTaskWorker());
}
```
I think it should be something like (!planTasks.isEmpty() ||
!initialFileScanTasks.isEmpty())?
##########
core/src/main/java/org/apache/iceberg/rest/ScanTaskIterable.java:
##########
@@ -202,15 +202,14 @@ public boolean hasNext() {
}
while (true) {
Review Comment:
btw @singhpk234 should the finally block above
```
if (remaining == 0
&& !planTasks.isEmpty()
&& !shutdown.get()
&& !initialFileScanTasks.isEmpty()) {
executorService.execute(new PlanTaskWorker());
}
```
I think it should be something like (!planTasks.isEmpty() ||
!initialFileScanTasks.isEmpty())?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
