rambleraptor commented on code in PR #2822:
URL: https://github.com/apache/iceberg-python/pull/2822#discussion_r2612481186


##########
tests/table/test_puffin.py:
##########
@@ -71,3 +71,78 @@ def test_map_high_vals() -> None:
 
     with pytest.raises(ValueError, match="Key 4022190063 is too large, max 
2147483647 to maintain compatibility with Java impl"):
         _ = _deserialize_bitmap(puffin)
+
+
+def test_puffin_round_trip() -> None:
+    # Define some deletion positions for multiple files
+    deletions1 = [10, 20, 30]

Review Comment:
   The Caller should provide a merged blob. I've changed this method to 
`set_blob` to make it more apparent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to