nandorKollar commented on PR #13186:
URL: https://github.com/apache/iceberg/pull/13186#issuecomment-3644050864

   > I was able to run the integration test locally after setting up azure key 
vault. Following [this 
guide](https://www.nuget.org/packages/Azure.Security.KeyVault.Keys) and LLM :)
   > 
   > ```
   > AZURE_KEYVAULT_URI="https://icebergkeyvaulttest.vault.azure.net/"; 
./gradlew :iceberg-azure:integrationTest --tests TestAzureKeyManagementClient
   > ```
   > 
   > had to make a slight adjust on the key vault env var and comment out these 
3 env vars
   > 
   > ```
   >   @EnabledIfEnvironmentVariable(named = "AZURE_CLIENT_ID", matches = ".*"),
   >   @EnabledIfEnvironmentVariable(named = "AZURE_CLIENT_SECRET", matches = 
".*"),
   >   @EnabledIfEnvironmentVariable(named = "AZURE_TENANT_ID", matches = ".*"),
   > ```
   > 
   > so that `DefaultAzureCredentialBuilder` will pick up the credentials from 
`az`. Otherwise, the test wont run unless I set those 3 env vars
   
   Do you think we should remove these env vars from the test, just keep 
AZURE_KEYVAULT_URI, or we can assume that they should be set for this test 
case, or some other authentication is available on the node, where the test is 
executed (like MSI for example on an Azure VM)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to