singhpk234 commented on code in PR #13400: URL: https://github.com/apache/iceberg/pull/13400#discussion_r2608035878
########## core/src/main/java/org/apache/iceberg/rest/RESTTable.java: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.rest; + +import java.util.Map; +import java.util.Set; +import java.util.function.Supplier; +import org.apache.iceberg.BaseTable; +import org.apache.iceberg.ImmutableTableScanContext; +import org.apache.iceberg.TableOperations; +import org.apache.iceberg.TableScan; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.metrics.MetricsReporter; + +class RESTTable extends BaseTable { Review Comment: One thing i realized its probably pretty late when the table api (to write iceberg metadata) will be invoked to commit to the table, because lets say in case of spark the executors would have attempted to write data files and only if they would have succeeded then would have sent back message to the driver which will not be the case. Me and @amogh-jahagirdar discussed this from spark pov if we can write an analyzer rule via custom extension, which detects that the query / df wants to do a write and then fails in the analysis phase saying write is not supported, WDYT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
