mbutrovich commented on issue #1914:
URL: https://github.com/apache/iceberg-rust/issues/1914#issuecomment-3638525914

   > Hi, [@mbutrovich](https://github.com/mbutrovich) this should not be a 
large feature to implement, so we quickly fix it if necessary. What I want to 
confirm is that we should return null if identity-partitioned columns return 
null, right?
   
   Hey @liurenjie1024!, yep that's my understanding. I think we fell through 
into that scenario before #1824.
   
   ## Workaround in DataFusion Comet
   
   We're working around this in Comet by skipping `NULL` partition values 
during serialization and relying on the Iceberg spec rule 4 to correctly 
resolve missing fields as `NULL`:
   
   
https://github.com/mbutrovich/datafusion-comet/blob/df51/spark/src/main/scala/org/apache/comet/serde/operator/CometIcebergNativeScan.scala#L391-L398


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to