ebyhr commented on code in PR #14798:
URL: https://github.com/apache/iceberg/pull/14798#discussion_r2604769862


##########
baseline.gradle:
##########
@@ -52,6 +52,7 @@ subprojects {
   apply plugin: 'com.palantir.baseline-exact-dependencies'
   apply plugin: 'com.diffplug.spotless'
 
+  String scalaVersion = System.getProperty("scalaVersion") != null ? 
System.getProperty("scalaVersion") : System.getProperty("defaultScalaVersion")

Review Comment:
   nit: We could call `getProperty(String key, String def)` instead, 
`System.getProperty("scalaVersion", 
System.getProperty("defaultScalaVersion"))`. Feel free to ignore this comment 
as pre-existing. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to