CTTY commented on code in PR #1917: URL: https://github.com/apache/iceberg-rust/pull/1917#discussion_r2604776461
########## crates/sqllogictest/testdata/slts/df_test/create_table.slt: ########## @@ -0,0 +1,44 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Test CREATE TABLE with simple schema +statement ok +CREATE TABLE default.default.test_create_simple ( + id INT, + name STRING +) + +# Verify table was created and is empty +query IT rowsort +SELECT * FROM default.default.test_create_simple +---- + +# Insert data to verify table works +query I +INSERT INTO default.default.test_create_simple VALUES (1, 'test') Review Comment: I think we don't need to insert here. Right now these slts are bits of everything mixed up. Need to come up with a way to clearly separate them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
