rizaon commented on code in PR #13560: URL: https://github.com/apache/iceberg/pull/13560#discussion_r2599376737
########## core/src/main/java/org/apache/iceberg/metrics/CacheMetrics.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.metrics; + +import com.github.benmanes.caffeine.cache.stats.CacheStats; +import org.immutables.value.Value; + [email protected] +public abstract class CacheMetrics { + public abstract long hitCount(); + + public abstract long missCount(); + + public abstract long loadSuccessCount(); + + public abstract long loadFailureCount(); + + public abstract long totalLoadTime(); + + public abstract long evictionCount(); + + public abstract long evictionWeight(); Review Comment: I look again at https://github.com/apache/iceberg/pull/4518 and saw many reference into the initial implementation of manifest caching in Iceberg java library. Having a standard API in Iceberg lib related to caching will be great. I'd be happy to contribute / review further improvement of manifest caching to help benefit the broader community Iceberg community. ########## core/src/main/java/org/apache/iceberg/metrics/CacheMetrics.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.metrics; + +import com.github.benmanes.caffeine.cache.stats.CacheStats; +import org.immutables.value.Value; + [email protected] +public abstract class CacheMetrics { + public abstract long hitCount(); + + public abstract long missCount(); + + public abstract long loadSuccessCount(); + + public abstract long loadFailureCount(); + + public abstract long totalLoadTime(); + + public abstract long evictionCount(); + + public abstract long evictionWeight(); Review Comment: Hi Gabor and Peter, Thank you for looking into this. I believe minimal cache metrics exposure is still better than nothing. In Apache Impala usecase, we usually display metrics like this in Coordinator / Catalog daemon WebUI and let metrics monitoring service scraping from it. Having ability to obeserve the cache metrics will help user tune the best config for their Iceberg usecase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
