liurenjie1024 commented on code in PR #1901: URL: https://github.com/apache/iceberg-rust/pull/1901#discussion_r2597926136
########## crates/catalog/rest/src/lib.rs: ########## @@ -53,6 +53,6 @@ mod catalog; mod client; -mod types; +pub mod types; Review Comment: We should follow patterns of exposing types in other modules: ``` pub use types::*; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
