smaheshwar-pltr commented on code in PR #14751:
URL: https://github.com/apache/iceberg/pull/14751#discussion_r2596981019
##########
aws/src/main/java/org/apache/iceberg/aws/AwsKeyManagementClient.java:
##########
@@ -102,4 +105,24 @@ public void close() {
kmsClient.close();
}
}
+
+ EncryptionAlgorithmSpec encryptionAlgorithmSpec() {
+ return encryptionAlgorithmSpec;
+ }
+
+ DataKeySpec dataKeySpec() {
+ return dataKeySpec;
+ }
+
+ private KmsClient kmsClient() {
Review Comment:
Noting the synchronization in this method, should `kmsClient` field be
`volatile` and also be closed with concurrency in mind? Similar to
https://github.com/apache/iceberg/blob/6735edd8494257af8cbfe92f38072136a2f97715/aliyun/src/main/java/org/apache/iceberg/aliyun/oss/OSSFileIO.java#L50-L52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
