c-thiel commented on code in PR #12584:
URL: https://github.com/apache/iceberg/pull/12584#discussion_r2594784911
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3405,6 +3513,66 @@ components:
allOf:
- $ref: '#/components/schemas/ScanTasks'
+ QueryEventsRequest:
+ type: object
+ properties:
+ page-token:
Review Comment:
I though about this a bit more. I like `continuation-token` much better now
- for two reasons:
1. The name is slightly clearer as you mentioned
2. Its probably not a good idea to re-use `PageToken` as it comes documented
as tri-option: Not specified (client doesn't support pagination), specified
null (first page) and specified some. This doesn't match with the event
endpoint that is useless without pagination.
I renamed it now to `continuation-token`, made the field in the response
required and use simple string type instead of the `PageToken` ref.
What do you think?
Diff:
https://github.com/apache/iceberg/pull/12584/commits/178ed3ed9e0722cba2ca3eee173add06c89e5df1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
