nastra commented on code in PR #14749:
URL: https://github.com/apache/iceberg/pull/14749#discussion_r2591733910
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -1152,6 +1159,25 @@ public void commitTransaction(SessionContext context,
List<TableCommit> commits)
ErrorHandlers.tableCommitHandler());
}
+ public LoadCredentialsResponse loadTableCredentials(
Review Comment:
the only place where this endpoint is relevant is actually in the
storage-related credential provider implementations, such as
`OAuth2RefreshCredentialsHandler` / `VendedCredentialsProvider` /
`VendedAdlsCredentialProvider`. The REST catalog itself never calls this
endpoint, so we don't need to add this here and in `RESTCatalog`.
For passing the `planId` to the credentials endpoint there is
https://github.com/apache/iceberg/pull/14767/commits/28eaf7ed7565e63e02dcb2f7819c96c3ca4e3e81
already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
