manuzhang commented on code in PR #13786:
URL: https://github.com/apache/iceberg/pull/13786#discussion_r2591374515
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatch.java:
##########
@@ -137,10 +137,24 @@ public PartitionReaderFactory createReaderFactory() {
}
private ParquetBatchReadConf parquetBatchReadConf(ParquetReaderType
readerType) {
- return ImmutableParquetBatchReadConf.builder()
- .batchSize(readConf.parquetBatchSize())
- .readerType(readerType)
- .build();
+ String factoryClassName = readConf.parquetVectorizedReaderFactory();
+
+ // If no explicit factory is set and reader type is COMET, use the default
Comet factory
+ if (factoryClassName == null && readerType == ParquetReaderType.COMET) {
+ factoryClassName =
+
org.apache.iceberg.spark.SparkSQLProperties.COMET_VECTORIZED_READER_FACTORY_CLASS;
Review Comment:
But you can import `SparkSQLProperties` and invoke like
`SparkSQLProperties.COMET_VECTORIZED_READER_FACTORY_CLASS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
