amogh-jahagirdar commented on code in PR #14739:
URL: https://github.com/apache/iceberg/pull/14739#discussion_r2589700511
##########
core/src/main/java/org/apache/iceberg/ContentFileParser.java:
##########
@@ -147,7 +155,7 @@ public static ContentFile<?> fromJson(JsonNode jsonNode,
Map<Integer, PartitionS
int specId = JsonUtil.getInt(SPEC_ID, jsonNode);
PartitionSpec spec = specsById.get(specId);
Preconditions.checkArgument(spec != null, "Invalid partition specId: %s",
specId);
- FileContent fileContent = FileContent.valueOf(JsonUtil.getString(CONTENT,
jsonNode));
+ FileContent fileContent = fileContentFromJson(JsonUtil.getString(CONTENT,
jsonNode));
Review Comment:
Minor: fileContentFromString
I also wouldn't be opposed to introducing a FileContent.fromString API that
does what fileContentFromString does below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
