singhpk234 commented on code in PR #14708:
URL: https://github.com/apache/iceberg/pull/14708#discussion_r2589588914
##########
core/src/main/java/org/apache/iceberg/rest/ExponentialHttpRequestRetryStrategy.java:
##########
@@ -97,6 +99,7 @@ class ExponentialHttpRequestRetryStrategy implements
HttpRequestRetryStrategy {
HttpStatus.SC_BAD_GATEWAY,
HttpStatus.SC_GATEWAY_TIMEOUT,
HttpStatus.SC_REQUEST_TIMEOUT);
+ this.retriableExceptions = ImmutableSet.of(SocketTimeoutException.class);
Review Comment:
retrying on socket timeout can cause table corruption due to self conflict,
since we don't have notion of idempotency key in the spec yet, community is
working towards adding this support, post that we can reconsider if we wanna
retry.
cc @huaxingao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
