mxm commented on code in PR #14728:
URL: https://github.com/apache/iceberg/pull/14728#discussion_r2584466119
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/EvolveSchemaVisitor.java:
##########
@@ -103,11 +121,16 @@ public Boolean struct(Types.StructType struct, Integer
partnerId, List<Boolean>
after = columnName;
}
- // Ensure that unused fields are made optional
for (Types.NestedField existingField : partnerStruct.fields()) {
if (struct.field(existingField.name()) == null) {
- if (existingField.isRequired()) {
-
this.api.makeColumnOptional(this.existingSchema.findColumnName(existingField.fieldId()));
+ String columnName =
this.existingSchema.findColumnName(existingField.fieldId());
+ if (dropUnusedColumns) {
+ LOG.info("{}: Dropping column: {}", identifier.name(), columnName);
Review Comment:
It logs for every record that triggers a schema change, but probably better
to change this to DEBUG.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
