Xuanwo commented on code in PR #1865:
URL: https://github.com/apache/iceberg-rust/pull/1865#discussion_r2584098981
##########
crates/catalog/glue/src/error.rs:
##########
@@ -22,7 +22,9 @@ use iceberg::{Error, ErrorKind};
/// Format AWS SDK error into iceberg error
pub(crate) fn from_aws_sdk_error<T>(error: aws_sdk_glue::error::SdkError<T>)
-> Error
-where T: Debug {
+where
Review Comment:
Why this change?
##########
crates/catalog/hms/tests/hms_catalog_test.rs:
##########
@@ -269,10 +269,10 @@ async fn test_list_tables() -> Result<()> {
catalog.create_table(ns.name(), creation).await?;
let result = catalog.list_tables(ns.name()).await?;
- assert_eq!(result, vec![TableIdent::new(
- ns.name().clone(),
- "my_table".to_string()
- )]);
+ assert_eq!(
+ result,
Review Comment:
There are many format related changes, it's better to avoid that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
