openinx commented on code in PR #14443:
URL: https://github.com/apache/iceberg/pull/14443#discussion_r2583686105
##########
aliyun/src/main/java/org/apache/iceberg/aliyun/AliyunClientFactories.java:
##########
@@ -81,17 +88,82 @@ private static AliyunClientFactory loadClientFactory(
}
static class DefaultAliyunClientFactory implements AliyunClientFactory {
+ private static final Logger LOG =
LoggerFactory.getLogger(DefaultAliyunClientFactory.class);
private AliyunProperties aliyunProperties;
DefaultAliyunClientFactory() {}
+ /**
+ * Check if RRSA environment variables are present. RRSA requires
Review Comment:
Is it possible to add more description about the `RRSA` ? Actually I also
don't have much context about this, which I think we need to provide more
context for others to understand and mantain this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
