nastra commented on code in PR #14608:
URL: https://github.com/apache/iceberg/pull/14608#discussion_r2581195457
##########
aws/src/test/java/org/apache/iceberg/aws/TestAwsClientProperties.java:
##########
@@ -189,17 +189,22 @@ public void
refreshCredentialsEndpointWithOverridingOAuthToken() {
"specific-token");
AwsClientProperties awsClientProperties = new
AwsClientProperties(properties);
- Map<String, String> expectedProperties =
- ImmutableMap.<String, String>builder()
- .putAll(properties)
- .put("credentials.uri", "http://localhost:1234/v1/credentials";)
- .build();
-
AwsCredentialsProvider provider =
awsClientProperties.credentialsProvider("key", "secret", "token");
assertThat(provider).isInstanceOf(VendedCredentialsProvider.class);
VendedCredentialsProvider vendedCredentialsProvider =
(VendedCredentialsProvider) provider;
-
assertThat(vendedCredentialsProvider).extracting("properties").isEqualTo(expectedProperties);
+ assertThat(vendedCredentialsProvider)
Review Comment:
@tom-s-powell can you update the PR description to mention what's currently
broken and what the PR addresses with a link to the commit that changed the
behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
