pvary commented on code in PR #14731: URL: https://github.com/apache/iceberg/pull/14731#discussion_r2580344104
########## format/spec.md: ########## @@ -1117,7 +1119,7 @@ Row-level delete files (both equality and position delete files) are valid Icebe Row-level delete files and deletion vectors are tracked by manifests. A separate set of manifests is used for delete files and DVs, but the same manifest schema is used for both data and delete manifests. Deletion vectors are tracked individually by file location, offset, and length within the containing file. Deletion vector metadata must include the referenced data file. -Both position and equality delete files allow encoding deleted row values with a delete. This can be used to reconstruct a stream of changes to a table. +Equality delete files allow encoding deleted row values with a delete. This can be used to reconstruct a stream of changes to a table. Review Comment: Just to clarify the situation: - In V1 - there is no position delete files - In V2 - It is allowed to encode the deleted row values in the position delete file. The java implementation will not read or write the deleted row values after Iceberg 1.12.0, but these position delete files will be valid - In V3 - there is no position delete files anymore So I think the original sentence is correct: ``` Both position and equality delete files allow encoding deleted row values [..] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
