huaxingao commented on code in PR #14652:
URL: https://github.com/apache/iceberg/pull/14652#discussion_r2579405670
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnarBatchReader.java:
##########
@@ -182,16 +133,5 @@ ColumnVector[] readDataToColumnVectors() {
return columnVectors;
}
-
- void readDeletedColumn(ColumnVector[] columnVectors, boolean[] isDeleted) {
- for (int i = 0; i < readers.length; i++) {
- if (readers[i] instanceof CometDeleteColumnReader) {
- CometDeleteColumnReader deleteColumnReader = new
CometDeleteColumnReader<>(isDeleted);
Review Comment:
nit: The constructor `CometDeleteColumnReader(boolean[] isDeleted)` is not
needed any more. Remove it from class `CometDeleteColumnReader`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
