blcksrx commented on code in PR #14440:
URL: https://github.com/apache/iceberg/pull/14440#discussion_r2578825669
##########
core/src/main/java/org/apache/iceberg/CachingCatalog.java:
##########
@@ -104,15 +158,28 @@ public void onRemoval(TableIdentifier tableIdentifier,
Table table, RemovalCause
}
private Cache<TableIdentifier, Table> createTableCache(Ticker ticker) {
- Caffeine<Object, Object> cacheBuilder = Caffeine.newBuilder().softValues();
-
- if (expirationIntervalMillis > 0) {
- return cacheBuilder
- .removalListener(new MetadataTableInvalidatingRemovalListener())
- .executor(Runnable::run) // Makes the callbacks to removal listener
synchronous
- .expireAfterAccess(Duration.ofMillis(expirationIntervalMillis))
- .ticker(ticker)
- .build();
+
+ if (expirationIntervalMillis <= 0) {
+ return Caffeine.newBuilder().softValues().build();
+ }
+
+ Caffeine<TableIdentifier, Table> cacheBuilder =
+ Caffeine.newBuilder()
+ .softValues()
+ .removalListener(new MetadataTableInvalidatingRemovalListener())
+ .executor(Runnable::run) // Makes the callbacks to removal
listener synchronous
+ .ticker(ticker);
+
+ switch (cacheExpirationPolicy) {
+ case EXPIRE_AFTER_WRITE:
+ cacheBuilder =
cacheBuilder.expireAfterWrite(Duration.ofMillis(expirationIntervalMillis));
Review Comment:
Im not following, this function is about create the cache table itself with
expireAfterWrtie policy or expireAfterAcessPolicy
##########
core/src/main/java/org/apache/iceberg/CachingCatalog.java:
##########
@@ -104,15 +158,28 @@ public void onRemoval(TableIdentifier tableIdentifier,
Table table, RemovalCause
}
private Cache<TableIdentifier, Table> createTableCache(Ticker ticker) {
- Caffeine<Object, Object> cacheBuilder = Caffeine.newBuilder().softValues();
-
- if (expirationIntervalMillis > 0) {
- return cacheBuilder
- .removalListener(new MetadataTableInvalidatingRemovalListener())
- .executor(Runnable::run) // Makes the callbacks to removal listener
synchronous
- .expireAfterAccess(Duration.ofMillis(expirationIntervalMillis))
- .ticker(ticker)
- .build();
+
+ if (expirationIntervalMillis <= 0) {
+ return Caffeine.newBuilder().softValues().build();
+ }
+
+ Caffeine<TableIdentifier, Table> cacheBuilder =
+ Caffeine.newBuilder()
+ .softValues()
+ .removalListener(new MetadataTableInvalidatingRemovalListener())
+ .executor(Runnable::run) // Makes the callbacks to removal
listener synchronous
+ .ticker(ticker);
+
+ switch (cacheExpirationPolicy) {
+ case EXPIRE_AFTER_WRITE:
+ cacheBuilder =
cacheBuilder.expireAfterWrite(Duration.ofMillis(expirationIntervalMillis));
Review Comment:
Im not following, this function is about create the cache table itself with
expireAfterWrtie policy or expireAfterAcess Policy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
