singhpk234 commented on code in PR #14723:
URL: https://github.com/apache/iceberg/pull/14723#discussion_r2577358524
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -324,6 +324,13 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
throw new RuntimeException("Cannot remove key in encrypted table");
}
+ if (base != null
+ && !Objects.equals(
+ base.properties().get(TableProperties.ENCRYPTION_TABLE_KEY),
+
metadata.properties().get(TableProperties.ENCRYPTION_TABLE_KEY))) {
+ throw new RuntimeException("Cannot modify key in encrypted table");
Review Comment:
should this be IllegalState / IllegalArgs exception ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
