HeartLinked commented on code in PR #361: URL: https://github.com/apache/iceberg-cpp/pull/361#discussion_r2572095056
########## CMakeLists.txt: ########## @@ -42,6 +42,7 @@ option(ICEBERG_BUILD_SHARED "Build shared library" OFF) option(ICEBERG_BUILD_TESTS "Build tests" ON) option(ICEBERG_BUILD_BUNDLE "Build the battery included library" ON) option(ICEBERG_BUILD_REST "Build rest catalog client" ON) +option(ICEBERG_BUILD_REST_INTEGRATION_TESTS "Build rest catalog integration tests" OFF) Review Comment: Yes, this is one of the main challenges encountered in this PR. I have addressed the platform-specific header files in `src/iceberg/test/util/CMakeLists.txt` and `src/iceberg/test/util/meson.build`. Do you have any specific follow-up questions or concerns? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
