greenlaw commented on issue #2659: URL: https://github.com/apache/iceberg-python/issues/2659#issuecomment-3577498673
Just ran into this as well. Seems `upsert` missing `snapshot_properties` was likely an oversight, shouldn't be too difficult to add. Regarding upsert performance, yes I agree it's not ideal that it produces two snapshots. It's also quite slow currently for large tables or a large number of upsert rows. I think there's a separate ticket that touches on both of those issues: https://github.com/apache/iceberg-python/issues/2159. I'm considering implementing my own upsert operation using some of the lower-level APIs to get around the performance issues, as well as supporting `upsert + delete` in a single operation, which currently requires 2 separate operations and generates 3 snapshots. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
