liurenjie1024 commented on code in PR #1849:
URL: https://github.com/apache/iceberg-rust/pull/1849#discussion_r2559325294
##########
crates/iceberg/src/spec/manifest/_serde.rs:
##########
@@ -258,6 +258,10 @@ fn parse_bytes_entry(v: Vec<BytesEntry>, schema: &Schema)
-> Result<HashMap<i32,
})?
.clone();
m.insert(entry.key, Datum::try_from_bytes(&entry.value,
data_type)?);
+ } else {
+ // Field is not in current schema (e.g., dropped field due to
schema evolution).
+ // Store the statistic as binary data to preserve it even though
we don't know its type.
+ m.insert(entry.key, Datum::binary(entry.value.to_vec()));
Review Comment:
> We could add a table with the reserved IDs
After https://github.com/apache/iceberg-rust/pull/1824 got merged, we will
have such a table. I think the problem this pr solved is more than just
reserved ids. After #1824 merged, maybe we could do a little refactoring to
this pr so that it's limited to reserved ids.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
