wgtmac commented on code in PR #334:
URL: https://github.com/apache/iceberg-cpp/pull/334#discussion_r2558531774
##########
src/iceberg/result.h:
##########
@@ -35,6 +35,7 @@ enum class ErrorKind {
kDecompressError,
kInvalid, // For general invalid errors
kInvalidArgument,
+ kValidationFailed,
Review Comment:
Please sort it alphabetically.
##########
src/iceberg/result.h:
##########
@@ -84,6 +85,7 @@ DEFINE_ERROR_FUNCTION(CommitStateUnknown)
DEFINE_ERROR_FUNCTION(DecompressError)
DEFINE_ERROR_FUNCTION(Invalid)
DEFINE_ERROR_FUNCTION(InvalidArgument)
+DEFINE_ERROR_FUNCTION(ValidationFailed)
Review Comment:
ditto
##########
src/iceberg/test/CMakeLists.txt:
##########
@@ -83,7 +83,8 @@ add_iceberg_test(table_test
json_internal_test.cc
table_test.cc
schema_json_test.cc
- table_metadata_builder_test.cc)
+ table_metadata_builder_test.cc
+ pending_update_test.cc)
Review Comment:
These files are unfortunately not sorted alphabetically. Could you help fix
it as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
