zhjwpku commented on code in PR #317:
URL: https://github.com/apache/iceberg-cpp/pull/317#discussion_r2556829071
##########
src/iceberg/v2_metadata.cc:
##########
@@ -83,11 +83,18 @@ Status ManifestEntryAdapterV2::Init() {
ICEBERG_ASSIGN_OR_RAISE(auto partition_type,
partition_spec_->PartitionType(*current_schema_));
+ partition_summary_ = std::make_unique<PartitionSummary>(*partition_type);
manifest_schema_ = EntrySchema(std::move(partition_type));
return ToArrowSchema(*manifest_schema_, &schema_);
}
Status ManifestEntryAdapterV2::Append(const ManifestEntry& entry) {
+ if (entry.IsAlive() && entry.sequence_number.has_value()) {
+ if (!min_sequence_number_.has_value() ||
Review Comment:
I do this mostly because the test case check, v1 doesn't maintain sequence
number, so its min_sequence_number_ should be kInvalidSequenceNumber. I think
we can do what you suggested and change the test case accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
