nastra commented on code in PR #14653:
URL: https://github.com/apache/iceberg/pull/14653#discussion_r2555501499
##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -63,6 +63,22 @@ public abstract class ViewCatalogTests<C extends ViewCatalog
& SupportsNamespace
@TempDir private Path tempDir;
+ protected String warehouseLocation() {
Review Comment:
what about using the same approach as we currently use in `CatalogTests`,
where we have a `protected String baseTableLocation(TableIdentifier
identifier)` which subclasses can override
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
