szlta commented on code in PR #14645:
URL: https://github.com/apache/iceberg/pull/14645#discussion_r2550155898


##########
core/src/test/java/org/apache/iceberg/puffin/TestPuffinWriter.java:
##########
@@ -86,6 +98,36 @@ public void testWriteMetricDataCompressedZstd() throws 
Exception {
     testWriteMetric(ZSTD, "v1/sample-metric-data-compressed-zstd.bin");
   }
 
+  @ParameterizedTest
+  @ValueSource(booleans = {true, false})
+  public void testLengthCalculation(boolean isEncrypted) throws Exception {

Review Comment:
   I opted for `testFileSizeCalculation` - since all the other test cases here 
are prepended with `test-`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to