zhjwpku commented on code in PR #337:
URL: https://github.com/apache/iceberg-cpp/pull/337#discussion_r2548844316
##########
src/iceberg/test/CMakeLists.txt:
##########
@@ -52,12 +52,20 @@ function(add_iceberg_test test_name)
target_sources(${test_name} PRIVATE ${ARG_SOURCES})
- if(ARG_USE_BUNDLE)
- target_link_libraries(${test_name} PRIVATE iceberg_bundle_static
GTest::gtest_main
- GTest::gmock)
+ target_link_libraries(${test_name} PRIVATE GTest::gtest_main GTest::gmock)
+
+ if("${ICEBERG_TEST_LINKAGE}" STREQUAL "shared")
Review Comment:
Could we just use `ICEBERG_BUILD_SHARED` and `ICEBERG_BUILD_STATIC` to
control the linkage behavior? For example:
- If only `ICEBERG_BUILD_SHARED=ON`, link against the shared libraries.
- If only `ICEBERG_BUILD_STATIC=ON`, link against the static libraries.
- If both are enabled, default to linking against the shared libraries (as
linking time will be shorter).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
