rdblue commented on code in PR #12298:
URL: https://github.com/apache/iceberg/pull/12298#discussion_r2547912452
##########
core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java:
##########
@@ -528,6 +528,18 @@ private static DeleteFile newEqualityDeleteEntry(
public interface PositionDeleteReaderWriter extends Serializable {
CloseableIterable<Record> reader(InputFile inputFile, FileFormat format,
PartitionSpec spec);
+ default PositionDeleteWriter<Record> writer(
+ OutputFile outputFile, FileFormat format, PartitionSpec spec,
StructLike partition)
+ throws IOException {
+ return writer(outputFile, format, spec, partition, null);
+ }
+
+ /**
+ * @deprecated This method is deprecated as of version 1.11.0 and will be
removed in 1.12.0.
+ * Position deletes that include row data are no longer supported. Use
{@link
+ * #writer(OutputFile, FileFormat, PartitionSpec, StructLike)} instead.
+ */
+ @Deprecated
Review Comment:
We already made the decision to remove support for position deletes with row
content right? In that case shouldn't this be part of a different PR to keep
this one smaller? I think that could possibly go in ahead of these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
