jonathanc-n commented on code in PR #1872: URL: https://github.com/apache/iceberg-rust/pull/1872#discussion_r2543213642
########## crates/iceberg/src/spec/table_properties.rs: ########## Review Comment: I was thinking about this, I think whether or not to place it in the `TableProperty` struct is currently a bit inconsistent. `write_format_default` and `write_target_file_size_bytes` don't seem to be called by `table_property.<property>` and are manually parsed in `write.rs`. I'm not sure why they are parsed differently, but should we standardize one way to do it? The different ways are currently calling `try_from` or parsing the way it is done in this pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
