nastra commented on code in PR #14614:
URL: https://github.com/apache/iceberg/pull/14614#discussion_r2540768695
##########
core/src/main/java/org/apache/iceberg/rest/requests/PlanTableScanRequestParser.java:
##########
@@ -101,6 +106,7 @@ public static PlanTableScanRequest fromJson(JsonNode json) {
Long snapshotId = JsonUtil.getLongOrNull(SNAPSHOT_ID, json);
Long startSnapshotId = JsonUtil.getLongOrNull(START_SNAPSHOT_ID, json);
Long endSnapshotId = JsonUtil.getLongOrNull(END_SNAPSHOT_ID, json);
+ Integer minRowsRequested = JsonUtil.getIntOrNull(MIN_ROWS_REQUESTED, json);
Review Comment:
I think you're right @amogh-jahagirdar. In hindsight I think it makes sense
to have this as a Long at the Spec layer. I've updated this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
