jonathanc-n commented on code in PR #1873:
URL: https://github.com/apache/iceberg-rust/pull/1873#discussion_r2540627055
##########
crates/catalog/s3tables/src/catalog.rs:
##########
@@ -42,7 +42,7 @@ pub const S3TABLES_CATALOG_PROP_ENDPOINT_URL: &str =
"endpoint_url";
/// S3Tables catalog configuration.
#[derive(Debug)]
-struct S3TablesCatalogConfig {
+pub(crate) struct S3TablesCatalogConfig {
Review Comment:
ditto
##########
crates/catalog/sql/src/catalog.rs:
##########
@@ -190,7 +201,7 @@ impl CatalogBuilder for SqlCatalogBuilder {
/// - `SqlBindStyle::DollarNumeric`: Binds SQL statements using `$1`, `$2`,
etc., as placeholders. This is for PostgreSQL databases.
/// - `SqlBindStyle::QuestionMark`: Binds SQL statements using `?` as a
placeholder. This is for MySQL and SQLite databases.
#[derive(Debug)]
-struct SqlCatalogConfig {
+pub(crate) struct SqlCatalogConfig {
Review Comment:
Bit of noise here, just to make it consistent with the other `CatalogConfigs`
##########
crates/catalog/glue/src/catalog.rs:
##########
@@ -65,6 +65,18 @@ impl Default for GlueCatalogBuilder {
}
}
+impl GlueCatalogBuilder {
+ /// Get a mutable reference to the catalog configuration.
+ pub(crate) fn catalog_config(&mut self) -> &mut GlueCatalogConfig {
+ &mut self.0
+ }
+
+ /// Consume the builder and return the catalog configuration.
+ pub(crate) fn into_config(self) -> GlueCatalogConfig {
Review Comment:
Need owned reference here as during catalog creation it needs the owned
config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
