zeroshade commented on code in PR #605:
URL: https://github.com/apache/iceberg-go/pull/605#discussion_r2539968124
##########
table/arrow_utils.go:
##########
@@ -616,6 +616,13 @@ func (c convertToArrow) VisitUUID() arrow.Field {
return arrow.Field{Type: extensions.NewUUIDType()}
}
+func (c convertToArrow) VisitUnknown() arrow.Field {
+ // UnknownType cannot be converted to Arrow as it has no concrete
representation
+ panic("cannot convert UnknownType to Arrow schema")
+}
Review Comment:
Where do you see that UnknownType fields are always null? The spec says
"Optional with null defaults, not stored in data files"
If it will always be null, then I guess this is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
