nastra commented on code in PR #13400:
URL: https://github.com/apache/iceberg/pull/13400#discussion_r2538792428
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -163,9 +179,19 @@ public <T extends RESTResponse> T execute(
Object body = roundTripSerialize(request.body(), "request");
HTTPRequest req =
ImmutableHTTPRequest.builder().from(request).body(body).build();
T response = super.execute(req, responseType, errorHandler,
responseHeaders);
+ if (response instanceof BaseScanTaskResponse) {
+ // This is for the case where the response does not roundTrip
Review Comment:
I'm not fully following why the response wouldn't roundtrip here. Isn't that
why we have the serializers and deseralizers configured for a given response
class?
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -163,9 +179,19 @@ public <T extends RESTResponse> T execute(
Object body = roundTripSerialize(request.body(), "request");
HTTPRequest req =
ImmutableHTTPRequest.builder().from(request).body(body).build();
T response = super.execute(req, responseType, errorHandler,
responseHeaders);
+ if (response instanceof BaseScanTaskResponse) {
+ // This is for the case where the response does not roundTrip
+ // the plan table related responses follow this case
+ return response;
+ }
T responseAfterSerialization = roundTripSerialize(response,
"response");
return responseAfterSerialization;
}
+
+ @Override
+ protected PlanningBehavior planningBehavior() {
Review Comment:
I think this should be removed as mentioned in
https://github.com/apache/iceberg/pull/13400/files#r2538769276
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -247,6 +273,57 @@ public static <T> T roundTripSerialize(T payload, String
description) {
return null;
}
+ /** Configurable planning behavior for tests. Replaces magic table
name-based behavior routing. */
Review Comment:
What does `Replaces magic table name-based behavior routing` actually mean
and where does that happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
