nandorKollar commented on code in PR #14499:
URL: https://github.com/apache/iceberg/pull/14499#discussion_r2535163034
##########
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/TestArrowReader.java:
##########
@@ -292,6 +302,87 @@ public void testHasNextIsIdempotent() throws Exception {
scan, NUM_ROWS_PER_MONTH, 12 * NUM_ROWS_PER_MONTH, 2, ALL_COLUMNS);
}
+ /**
+ * Tests that VectorizedArrowReader correctly reads Parquet files with
TIMESTAMP_MILLIS logical
+ * type. The test writes a Parquet file with millisecond-precision
timestamps using the low-level
+ * Parquet API, then reads it via VectorizedArrowReader.
+ */
+ @Test
+ public void testTimestampMillisAreReadCorrectly() throws Exception {
+ tables = new HadoopTables();
+ Schema schema =
+ new Schema(Types.NestedField.required(1, "ts_millis",
Types.TimestampType.withZone()));
+
+ Table table = tables.create(schema, tableLocation);
+
+ File testFile = new File(tempDir, "timestamp-millis-test.parquet");
Review Comment:
nit: would it be possible to use `InMemoryOutputFile` instead of temp files?
We can maybe rewrite the Arrow tests in a subsequent followup PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
