tmater commented on code in PR #14588:
URL: https://github.com/apache/iceberg/pull/14588#discussion_r2534309708
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquetSchemaUtil.java:
##########
@@ -224,7 +237,16 @@ public void testSchemaConversionWithoutAssigningIds() {
"map_col_5",
Repetition.REQUIRED,
primitive(28, "k", PrimitiveTypeName.INT32,
Repetition.REQUIRED),
- primitive(29, "v", PrimitiveTypeName.INT32,
Repetition.REQUIRED)));
+ primitive(29, "v", PrimitiveTypeName.INT32,
Repetition.REQUIRED)),
+ variant(30, "variant_col_1", Repetition.OPTIONAL),
+ variant(null, "variant_col_2", Repetition.REQUIRED),
+ list(31, "list_col_6", Repetition.OPTIONAL, variant(32, "v",
Repetition.OPTIONAL)),
Review Comment:
Updated this test, but reached the 150-line Checkstyle limit, so I moved the
variant-related tests into separate methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
