ggershinsky commented on code in PR #14579:
URL: https://github.com/apache/iceberg/pull/14579#discussion_r2533109499
##########
core/src/main/java/org/apache/iceberg/encryption/AesGcmOutputFile.java:
##########
@@ -50,6 +50,6 @@ public String location() {
@Override
public InputFile toInputFile() {
- return new AesGcmInputFile(targetFile.toInputFile(), dataKey,
fileAADPrefix);
+ throw new IllegalStateException("File length unknown, creating an
AesGcmInputFile is not safe");
Review Comment:
This method is required by the `OutputFile` interface, I guess we cannot
deprecate it.
How much of a problem is that exception? The CI passes ok, since this method
is never called on an AesGcmOutputFile (which is a correct behavior)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
