emkornfield commented on code in PR #1851:
URL: https://github.com/apache/iceberg-rust/pull/1851#discussion_r2530469094
##########
crates/iceberg/src/transaction/snapshot.rs:
##########
@@ -205,7 +220,9 @@ impl<'a> SnapshotProducer<'a> {
.default_partition_spec()
.as_ref()
.clone(),
- );
+ )
+ .with_compression(compression);
Review Comment:
I don't know that there is strong reason one way or another, happy to do
whatever reviewers prefer. As an argument against adding another parameter to
the construct, Rust has clippy warnings for too many parameters, so for
optional parameters it seems best not to add them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
