stevenzwu commented on code in PR #14504:
URL: https://github.com/apache/iceberg/pull/14504#discussion_r2528412663
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -821,6 +821,9 @@ public void testHistoryTable() {
// rollback the table state to the first snapshot
table.manageSnapshots().rollbackTo(firstSnapshotId).commit();
long rollbackTimestamp =
Iterables.getLast(table.history()).timestampMillis();
+ assertThat(rollbackTimestamp)
+ .as("Rollback history timestamp should be greater than first snapshot
timestamp")
+ .isGreaterThan(firstSnapshotTimestamp);
Review Comment:
should we assert that the `rollbackTimestamp` is equal to the
`tableMetadata.lastUpdatedMillis()` for the first commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
