nbdevos25 commented on code in PR #14161:
URL: https://github.com/apache/iceberg/pull/14161#discussion_r2525004236
##########
aws/src/main/java/org/apache/iceberg/aws/UrlConnectionHttpClientConfigurations.java:
##########
@@ -36,10 +40,20 @@ class UrlConnectionHttpClientConfigurations {
private UrlConnectionHttpClientConfigurations() {}
public <T extends AwsSyncClientBuilder> void configureHttpClientBuilder(T
awsClientBuilder) {
- UrlConnectionHttpClient.Builder urlConnectionHttpClientBuilder =
- UrlConnectionHttpClient.builder();
- configureUrlConnectionHttpClientBuilder(urlConnectionHttpClientBuilder);
- awsClientBuilder.httpClientBuilder(urlConnectionHttpClientBuilder);
+ String cacheKey = generateHttpClientCacheKey();
Review Comment:
nit: because this is a "key" does it make sense to make it final?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
