pvary commented on code in PR #14578:
URL: https://github.com/apache/iceberg/pull/14578#discussion_r2522616046


##########
docs/docs/flink-writes.md:
##########
@@ -523,19 +523,20 @@ To improve cache hit rates and performance, reuse the 
same DynamicRecord.schema
 
 The Dynamic Iceberg Flink Sink is configured using the Builder pattern. Here 
are the key configuration methods:
 
-| Method                                               | Description           
                                                                                
                                                                  |
-|------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| `overwrite(boolean enabled)`                         | Enable overwrite mode 
                                                                                
                                                                  |
-| `writeParallelism(int parallelism)`                  | Set writer 
parallelism                                                                     
                                                                             |
-| `uidPrefix(String prefix)`                           | Set operator UID 
prefix                                                                          
                                                                       |
-| `snapshotProperties(Map<String, String> properties)` | Set snapshot metadata 
properties                                                                      
                                                                  |
-| `toBranch(String branch)`                            | Write to a specific 
branch                                                                          
                                                                    |
-| `cacheMaxSize(int maxSize)`                          | Set cache size for 
table metadata                                                                  
                                                                     |
-| `cacheRefreshMs(long refreshMs)`                     | Set cache refresh 
interval                                                                        
                                                                      |
-| `inputSchemasPerTableCacheMaxSize(int size)`         | Set max input schemas 
to cache per table                                                              
                                                                  |
-| `immediateTableUpdate(boolean enabled)`              | Controls whether 
table metadata (schema/partition spec) updates immediately (default: false)     
                                                                                
                                                                              |
-| `set(String property, String value)`                 | Set any Iceberg write 
property (e.g., `"write.format"`, `"write.upsert.enabled"`).Check out all the 
options here: [write-options](flink-configuration.md#write-options) |
-| `setAll(Map<String, String> properties)`             | Set multiple 
properties at once                                                              
                                                                           |
+| Method                                               | Description           
                                                                                
                                                                        |
+|------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| `overwrite(boolean enabled)`                         | Enable overwrite mode 
                                                                                
                                                                        |
+| `writeParallelism(int parallelism)`                  | Set writer 
parallelism                                                                     
                                                                                
   |
+| `uidPrefix(String prefix)`                           | Set operator UID 
prefix                                                                          
                                                                             |
+| `snapshotProperties(Map<String, String> properties)` | Set snapshot metadata 
properties                                                                      
                                                                        |
+| `toBranch(String branch)`                            | Write to a specific 
branch                                                                          
                                                                          |
+| `cacheMaxSize(int maxSize)`                          | Set cache size for 
table metadata                                                                  
                                                                           |
+| `cacheRefreshMs(long refreshMs)`                     | Set cache refresh 
interval                                                                        
                                                                            |
+| `inputSchemasPerTableCacheMaxSize(int size)`         | Set max input schemas 
to cache per table                                                              
                                                                        |
+| `immediateTableUpdate(boolean enabled)`              | Controls whether 
table metadata (schema/partition spec) updates immediately (default: false)     
                                                                             |
+| `set(String property, String value)`                 | Set any Flink-Iceberg 
write property (e.g., `"write.format"`, `"write.upsert.enabled"`).Check out all 
the options here: [write-options](flink-configuration.md#write-options) |
+| `setAll(Map<String, String> properties)`             | Set multiple 
Flink-Iceberg write properties at once                                          
                                                                                
 |
+| `tableDefaultProperties(Map<String, String> props)`  | When 
DynamicIcebergSink creates new Iceberg tables, sets these table properties (via 
UpdateProperties API)                                                           
         |

Review Comment:
   Please not reformat the table. It is hard to find the things that are changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to