anuragmantri commented on code in PR #14501:
URL: https://github.com/apache/iceberg/pull/14501#discussion_r2520013210
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##########
@@ -211,6 +213,27 @@ private ExecutorService executorService() {
return executorService;
}
+ private void deletePath(FileSystem fs, Path toDelete, boolean recursive)
throws IOException {
+ if (!shouldUseTrashIfConfigured()) {
+ fs.delete(toDelete, recursive);
+ return;
+ }
+ Trash trash = new Trash(fs, getConf());
+ if (!trash.isEnabled()) {
Review Comment:
Sorry, my understanding was that the current java API for delete always
"ignores" the trash config even if it is set server side. In which case, not
ignoring it anymore could be potentially unexpected. But I guess that is the
right thing to do (honor the trash config if it is set via Hadoop conf). I'm ok
with just using the Hadoop conf. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
